lkml.org 
[lkml]   [2007]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH 4/5 v3] Add RapidIO support to powerpc architecture.
Date
From
Hi, Kumar, 

> -----Original Message-----
> From: Kumar Gala [mailto:galak@kernel.crashing.org]
> On Jul 26, 2007, at 3:42 AM, Zhang Wei wrote:
>
> > This patch adds the RapidIO support to the powerpc architecture.
> > Some files are moved from ppc. OF-tree and OF-device supports are
> > added.
> > New silicons such as MPC8548, MPC8641 with serial RapidIO
> > controller are
> > all supported.
> > Memory driver hardware operations are added.
> > Global mport variables are changed to master port private variables.
> > Multi master ports are supported.
> >
> > Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
> > ---
> > arch/powerpc/Kconfig | 8 +
> > arch/powerpc/kernel/Makefile | 1 +
> > arch/powerpc/kernel/rio.c | 64 ++
> > arch/powerpc/sysdev/Makefile | 1 +
> > arch/powerpc/sysdev/fsl_rio.c | 1455
> ++++++++++++++++++++++++++++++
> > +++++++++++
>
> how much of this moved from ppc85xx_rio.c?

From the code size, 2/3 are moved from pcc85xx_rio.c with clean up, 1/3
are new coding.

>
> > arch/powerpc/sysdev/fsl_rio.h | 20 +
> > 6 files changed, 1549 insertions(+), 0 deletions(-)
> > create mode 100644 arch/powerpc/kernel/rio.c
> > create mode 100644 arch/powerpc/sysdev/fsl_rio.c
> > create mode 100644 arch/powerpc/sysdev/fsl_rio.h
> >
> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> > index 00099ef..45f32f1 100644
> > --- a/arch/powerpc/Kconfig
> > +++ b/arch/powerpc/Kconfig
> > @@ -492,6 +492,14 @@ source "drivers/pci/Kconfig"
> >
> > source "drivers/pcmcia/Kconfig"
> >
> > +config RAPIDIO
> > + bool "RapidIO support" if MPC8540 || MPC8560 || MPC8641
> || MPC8548
> > + help
> > + If you say Y here, the kernel will include drivers and
> > + infrastructure code to support RapidIO interconnect devices.
>
> why not make this depend on something like HAS_RAPIDIO and let the
> boards select HAS_RAPIDIO if they have it

It's more clear, We can know how many and which processors support
RapidIO. :-)

>
> > +
> > +source "drivers/rapidio/Kconfig"
> > +
> > source "drivers/pci/hotplug/Kconfig"
> >
> > endmenu
> > diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/
> > Makefile
> > index 42c42ec..02d4100 100644
> > --- a/arch/powerpc/kernel/Makefile
> > +++ b/arch/powerpc/kernel/Makefile
> > @@ -70,6 +70,7 @@ pci64-$(CONFIG_PPC64) +=
> pci_64.o pci_dn.o isa-
> > bridge.o
> > pci32-$(CONFIG_PPC32) := pci_32.o
> > obj-$(CONFIG_PCI) += $(pci64-y) $(pci32-y) pci-common.o
> > obj-$(CONFIG_PCI_MSI) += msi.o
> > +obj-$(CONFIG_RAPIDIO) += rio.o
>
> should probably live in sysdev/rio.c

This just keep the same position of ppc arch.

Thanks!
-zw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-27 11:05    [W:0.078 / U:1.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site