Messages in this thread | | | Date | Sat, 28 Jul 2007 11:47:19 +0800 | From | Joe Jin <> | Subject | Re: [PATCH] add check do_direct_IO() return val |
| |
> I tested Andrew's patch and panic was gone but got few ENOTBLK. > So I tried with Joe's patch , both panic and ENOTBLK are gone now. > But in Joe's patch if (ret == -ENOTBLK && (rw & WRITE)), dio_cleanup(dio) > was not getting called because of break. So I moved dio_cleanup just > after if (ret).
Guru, actually, break from the loop with ENOTBLK will call dio_cleanup at leater, if call it too early, that means will put_page(), maybe cause other panic.
Thanks, Joe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |