lkml.org 
[lkml]   [2007]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] add check do_direct_IO() return val
    > I tested Andrew's patch and panic was gone but got few ENOTBLK.
    > So I tried with Joe's patch , both panic and ENOTBLK are gone now.
    > But in Joe's patch if (ret == -ENOTBLK && (rw & WRITE)), dio_cleanup(dio)
    > was not getting called because of break. So I moved dio_cleanup just
    > after if (ret).

    Guru, actually, break from the loop with ENOTBLK will call dio_cleanup
    at leater, if call it too early, that means will put_page(), maybe cause
    other panic.

    Thanks,
    Joe
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-28 05:49    [W:0.033 / U:28.860 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site