lkml.org 
[lkml]   [2007]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] remove hugetlb_instantiation_mutex
    From
    Date
    Hey... I am amazed at how quickly you came back with a patch for this :)
    Thanks for looking at it. Unfortunately there is one show-stopper and I
    have some reservations (pun definitely intended) with your approach:

    First, your patch does not pass the libhugetlbfs test
    'alloc-instantiate-race' which was written to tickle the the race which
    the mutex was introduced to solve. Your patch works for shared
    mappings, but not for the private case.

    Second, the introduction of another pair of global counters triggers my
    internal warning system... These global counters are known to cause
    problems with NUMA and cpusets. Have you considered these interactions?
    Additionally, the commit/rollback logic you are using closely parallels
    what we already do with the huge page reservation mechanism. Is there
    any way you could integrate your stuff into the reservation system to
    avoid all the duplicated logic?

    --
    Adam Litke - (agl at us.ibm.com)
    IBM Linux Technology Center

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-27 18:41    [W:4.130 / U:0.852 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site