Messages in this thread | | | Date | Fri, 27 Jul 2007 11:16:28 +1200 | From | "Ian McDonald" <> | Subject | Re: [PATCH][dccp] Fix memory leak and clean up style - dccp_feat_empty_confirm() |
| |
On 7/27/07, Jesper Juhl <jesper.juhl@gmail.com> wrote: > > Greetings, > > There's a memory leak in net/dccp/feat.c::dccp_feat_empty_confirm(). > If we hit the 'default:' case of the 'switch' statement, then we > return without freeing 'opt', thus leaking 'struct dccp_opt_pend' > bytes. > The leak is fixed easily enough by adding a kfree(opt); before the > return statement. > The patch also changes the layout of the 'switch' to be more in line > with CodingStyle. > > Patch has been compile tested. > > Please consider merging. > > > Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz> -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |