Messages in this thread | | | Date | Wed, 25 Jul 2007 10:44:59 -0700 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH][RFC] getting rid of stupid loop in BUG() |
| |
Al Viro wrote: > On Wed, Jul 25, 2007 at 09:56:12AM -0700, Linus Torvalds wrote: > >> We don't just do the "ud2" instruction - we also do the file and line >> number information after it. Which means that __builtin_trap() is useless. >> >> So we might as well keep the loop, since both are two-byte instructions >> that tell gcc that it will never continue. >> > > Actually, the worse problem is that gcc will happily merge these guys. > And that's a killer. >
Merge __builtin_traps()? Ugh. But also, there's no real long-term guarantee that it will keep generating ud2a. The *only* mention of it in the manual is a discussion that it will emit a call to abort() on arches which don't otherwise support it.
J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |