Messages in this thread | | | Date | Wed, 25 Jul 2007 09:56:12 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH][RFC] getting rid of stupid loop in BUG() |
| |
On Tue, 24 Jul 2007, David Miller wrote: > > From: Jeremy Fitzhardinge <jeremy@goop.org> > Date: Tue, 24 Jul 2007 23:24:55 -0700 > > > H. Peter Anvin wrote: > > > How far back was __builtin_trap() supported? > > > > I think its relatively recent, but it might be within our supported > > compiler window. > > I'm pretty sure it is.
.. and I'm pretty sure it's immaterial.
We don't just do the "ud2" instruction - we also do the file and line number information after it. Which means that __builtin_trap() is useless.
So we might as well keep the loop, since both are two-byte instructions that tell gcc that it will never continue.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |