Messages in this thread | | | Date | Tue, 24 Jul 2007 00:09:47 -0700 (PDT) | From | Christoph Lameter <> | Subject | Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK |
| |
On Tue, 24 Jul 2007, Peter Zijlstra wrote:
> Then we can either fixup the slab allocators to mask out __GFP_ZERO, or > do something like the below. > > Personally I like the consistency of adding __GFP_ZERO here (removes > this odd exception) and just masking it in the sl[aou]b thingies.
There is another exception for __GFP_DMA.
> Anybody else got a preference?
> #define __GFP_BITS_MASK ((__force gfp_t)((1 << __GFP_BITS_SHIFT) - 1)) > > -/* if you forget to add the bitmask here kernel will crash, period */ > +/* > + * If you forget to add the bitmask here kernel will crash, period! > + * > + * GFP_LEVEL_MASK is used to filter out the flags that are to be passed to the > + * page allocator. > + *
GFP_LEVEL_MASK is also used in mm/vmalloc.c. We need a definition that goes beyond slab allocators.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |