[lkml]   [2007]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] update to version 0.08
On Tue, Jul 24, 2007 at 02:15:26AM -0700, Andrew Morton wrote:
> On Tue, 24 Jul 2007 10:06:51 +0100 Andy Whitcroft <> wrote:
> > > This is a royal pain, since it now throws an ERROR for the obviously
> > > preferable piece of code below:
> > >
> > > if (err) {
> > > do_something();
> > > return -ERR;
> > > } else {
> > > do_somthing_else();
> > > }
> >
> > Hmmm, is that obviouly nicer than the below? Its fully a line longer
> > for no benefit. But ignoring that, this seems to have snuck in to
> > CodingStyle hmmm ... will see what I can do if anything to stop these
> > being picked up I guess.
> >
> > if (err) {
> > do_something();
> > return -ERR;
> > } else
> > do_something_else();
> The kool kids on linux-usb-devel largely ended up deciding that the second
> version looks dorky.
Since when did linux-usb-devel decide stylistic nits of the rest of the
kernel? Let them do what they want in drivers/usb, I have a hard time
accepting that what someone arbitrarily decides they want to do in their
directory suddenly blanketly applies to the rest of the kernel, and
therefore warrants a CodingStyle update.

Perhaps CodingStyle can start being versioned, so people can opt out of
certain 'improvements' whenever someone has a vision, much like some
nameless licenses.

Personally I prefer the second style, and if there's a comment block,
then it makes sense to complete the tree with {}'s (the keyword here is
prefer, as it's a personal preference). checkpatch has been quite useful
for catching obviously broken things, and now it seems like it's just
overreaching. Perhaps this functionality can be split in to a lite
checkpatch for catching show-stoppers for application and then something
more akin to a CodingStyle validator for the folks interested in
arbitrarily defining convention, which they can use freely while the rest
of us try to get something useful done.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-07-24 19:25    [W:0.618 / U:1.312 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site