lkml.org 
[lkml]   [2007]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC 1/8]KVM: fix bugs in kvm sched integration patch
    Shaohua Li wrote:
    >>
    >>> 1. vmcs_readl/vmcs_writel are called with preempt enabled
    >>>
    >>>
    >> Why is that bad?
    >>
    > 1. raw_smp_processor_id()
    > 2. migrate to other cpu
    > 3. current->kvm_vcpu->cpu != the cpu id of step 1.
    > you will see the warning.
    >

    Ah, that code is gone from preempt-hooks, hence I didn't understand you.

    The current version of the patchset does not change
    vmcs_readl/vmcs_writel. So I think everything is safe.

    --
    Do not meddle in the internals of kernels, for they are subtle and quick to panic.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-24 07:37    [W:0.022 / U:1.032 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site