Messages in this thread | | | Date | Tue, 24 Jul 2007 15:57:28 +0300 (EEST) | From | Petko Manolov <> | Subject | Re: [PATCH] [2.6.22] Fix a potential NULL pointer dereference in write_bulk_callback() in drivers/net/usb/pegasus.c |
| |
ACK :-)
cheers, Petko
On Mon, 23 Jul 2007, Micah Gruber wrote:
> This patch fixes a potential null dereference bug where we dereference > pegasus before a null check. This patch simply moves the dereferencing after > the null check. > > Signed-off-by: Micah Gruber <micah.gruber@gmail.com> > > --- > > --- a/drivers/net/usb/pegasus.c > +++ b/drivers/net/usb/pegasus.c > @@ -768,11 +768,13 @@ > static void write_bulk_callback(struct urb *urb) > { > pegasus_t *pegasus = urb->context; > - struct net_device *net = pegasus->net; > + struct net_device *net; > > if (!pegasus) > return; > > + net = pegasus->net; > + > if (!netif_device_present(net) || !netif_running(net)) > return; > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |