Messages in this thread Patch in this message | | | Date | Tue, 24 Jul 2007 02:09:39 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH]: allow individual core dump methods to be unlimited when sending to a pipe |
| |
On Sun, 22 Jul 2007 11:39:47 -0400 Neil Horman <nhorman@tuxdriver.com> wrote:
> This is a follow on to the patch entitled: > update-coredump-path-in-kernel-to-not-check-coredump-rlim-if-core_pattern-is-a-pipe.patch > It allows individual core dump methods to have the core dump size limit passed > into them. Its more efficient than each method having to retrieve it on their > own, and it allows for do_coredump to specify a infinite limit in the event that > a pipe is configured in /proc/sys/kernel/core_pattern, in which case ulimit -c > should not apply.
Needed this warning fix:
fs/exec.c: In function 'do_coredump': fs/exec.c:1761: warning: large integer implicitly truncated to unsigned type
diff -puN fs/exec.c~allow-individual-core-dump-methods-to-be-unlimited-when-sending-to-a-pipe-fix fs/exec.c --- a/fs/exec.c~allow-individual-core-dump-methods-to-be-unlimited-when-sending-to-a-pipe-fix +++ a/fs/exec.c @@ -1703,7 +1703,7 @@ int do_coredump(long signr, int exit_cod int fsuid = current->fsuid; int flag = 0; int ispipe = 0; - u32 core_limit = current->signal->rlim[RLIMIT_CORE].rlim_cur; + unsigned long core_limit = current->signal->rlim[RLIMIT_CORE].rlim_cur; audit_core_dumps(signr); _ which makes me worry about how much care was taken here on 32/64 issues, and crsos-arch issues (the underlying type for compat_ulong_t, for one).
Could you please go over it with a toothcomb, see if there are any other slipups there?
Thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |