Messages in this thread | | | Date | Mon, 23 Jul 2007 16:00:24 -0700 (PDT) | From | Christoph Lameter <> | Subject | Re: [PATCH] add __GFP_ZERP to GFP_LEVEL_MASK |
| |
On Mon, 23 Jul 2007, Andrew Morton wrote:
> So this: > > /* > * Be lazy and only check for valid flags here, keeping it out of the > * critical path in kmem_cache_alloc(). > */ > BUG_ON(flags & ~(GFP_DMA | __GFP_ZERO | GFP_LEVEL_MASK)); > > would no longer need the __GFP_ZERO. Ditto in slob's new_slab().
That __GFP_ZERO is needed to avoid triggering the BUG_ON. The next line
local_flags = (flags & GFP_LEVEL_MASK);
filters out the __GFP_ZERO before calling the page allocator. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |