lkml.org 
[lkml]   [2007]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] release quicklist before free_page

* Daniel Walker <dwalker@mvista.com> wrote:

> > Not quite, it uses preempt_disable() to avoid migration and stick to
> > a cpu. Without that it might end up freeing pages from another
> > quicklist.

i.e. the patch hides a debug warning and there's possibly silent data
corruption - not good.

> > How about this - compile tested only
>
> How about a comment to go with it ? Which says something like what's
> above, notes on how the locking is getting used..

how about: "if you've got some time then please also add a few comments,
because the code was quite non-obvious to me and I misunderstood it when
I tried to fix it. Thanks."

ok?

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-23 20:27    [W:0.065 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site