lkml.org 
[lkml]   [2007]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/8] i386: bitops: Kill volatile-casting of memory addresses


On Mon, 23 Jul 2007, Satyam Sharma wrote:

>
> [4/8] i386: bitops: Kill volatile-casting of memory addresses

This is wrong.

The "const volatile" is so that you can pass an arbitrary pointer. The
only kind of abritraty pointer is "const volatile".

In other words, the "volatile" has nothing at all to do with whether the
memory is volatile or not (the same way "const" has nothing to do with it:
it's purely a C type *safety* issue, exactly the same way "const" is a
type safety issue.

A "const" on a pointer doesn't mean that the thing it points to cannot
change. When you pass a source pointer to "strlen()", it doesn't have to
be constant. But "strlen()" takes a "const" pointer, because it work son
constant pointers *too*.

Same deal here.

Admittedly this may be mostly historic, but regardless - the "volatiles"
are right.

Using volatile on *data* is generally considered incorrect and bad taste,
but using it in situations like this potentially makes sense.

Of course, if we remove all "volatiles" in data in the kernel (with the
possible exception of "jiffies"), we can then remove them from function
declarations too, but it should be done in that order.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-23 19:55    [W:0.130 / U:2.816 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site