Messages in this thread | | | Date | Sun, 22 Jul 2007 16:49:23 +0200 | From | Sam Ravnborg <> | Subject | Re: [DRIVER SUBMISSION] DRBD wants to go mainline |
| |
On Sun, Jul 22, 2007 at 03:58:14PM +0200, Lars Ellenberg wrote: > On Sun, Jul 22, 2007 at 07:52:36AM +0200, Jens Axboe wrote: > > On Sun, Jul 22 2007, Andi Kleen wrote: > > > Lars Ellenberg <lars@linbit.com> writes: > > > > > > > > Jens, Andrew, anyone: please review, > > > > and give me advice how to proceed from here. > > > > > > The standard procedure would be to post all the source code in logical > > > pieces on the list for review. Then iterate until all comments are > > > addressed. > > > > Yep, cleanup the style issues (that make sense) from checkpatch and then > > psot as a series of patches that can be reviewed. Linking to a git tree > > wont get you very far. > > it got me far enough, for the first try, anyways :-) > I did not spam the lkml with patches, and still got some very useful > advice (no idea how I could overlook the checkpatch.pl complaints). > > If each patch of a series needs to compile and work, > there will probably only one 17kB patch... Thats not needed for reviewing..
> 33 WARNING: line over 80 characters > hmmm. get more ugly... > probably need some helper functions and temp variables?
Several people question this check. It gets ugly on text-mode but for the price of readability for the rest. So I suggest concentrate on other matters, but keep an eye for the "many small functions that do exactly _one_ thing and few local variables" approach.
Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |