Messages in this thread Patch in this message | | | Date | Fri, 20 Jul 2007 18:18:15 -0400 | Subject | [PATCH] knfsd: Fix typo in export display, print uid and gid as unsigned | From | "J. Bruce Fields" <> |
| |
From: J. Bruce Fields <bfields@citi.umich.edu>
For display purposes, treat uid's and gid's as unsigned ints for now. Also fix a typo.
Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu> --- fs/nfsd/export.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
On Fri, Jul 20, 2007 at 12:21:16PM +1000, Neil Brown wrote: > On Thursday July 19, bfields@fieldses.org wrote: > > Sharp eyes, thanks! I'll make a patch. Uh, any objection if I print > > all those uid's as unsigned while I'm at it? > > I wondered about that too. I think we have completely removed the > fiction that 'nobody' is '-2' rather than '65534' so it should be both > safe and sensible to make them unsigned.
OK! Here's what I've got.--b.
diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c index 6ab8de4..2d295dd 100644 --- a/fs/nfsd/export.c +++ b/fs/nfsd/export.c @@ -1503,9 +1503,9 @@ static void exp_flags(struct seq_file *m, int flag, int fsid, if (flag & NFSEXP_FSID) seq_printf(m, ",fsid=%d", fsid); if (anonu != (uid_t)-2 && anonu != (0x10000-2)) - seq_printf(m, ",sanonuid=%d", anonu); + seq_printf(m, ",anonuid=%u", anonu); if (anong != (gid_t)-2 && anong != (0x10000-2)) - seq_printf(m, ",sanongid=%d", anong); + seq_printf(m, ",anongid=%u", anong); if (fsloc && fsloc->locations_count > 0) { char *loctype = (fsloc->migrated) ? "refer" : "replicas"; int i; -- 1.5.3.rc2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |