Messages in this thread | | | Date | Fri, 20 Jul 2007 13:47:36 -0400 | From | "Dmitry Torokhov" <> | Subject | Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible |
| |
Hi Geert,
On 7/20/07, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > From: Geert Uytterhoeven <geert@linux-m68k.org> > > m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible > > drivers/char/keyboard.c: In function 'kbd_keycode': > drivers/char/keyboard.c:1142: error: implicit declaration of function 'mac_hid_mouse_emulate_buttons' > > The forward declaration of mac_hid_mouse_emulate_buttons() is not visible on > m68k because it's hidden in the middle of a big #ifdef block. > > Move it to <linux/hid.h>, correct the type of the second parameter, and > include <linux/hid.h> where needed.
linux/hid.h contains definitions needed for drivers speaking HID protocol, I don't think we want to put quirks for legacy keyboard driver there. I'd just move the #ifdef within drivers/char/keyboard.c for now.
BTW, I don't think that mac button emulation will work well when x86 evdev-based driver gains popularity - it "grabs" the device and so no event will flow through keyboard driver... We'd need a new solution...
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |