lkml.org 
[lkml]   [2007]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] [3/11] x86: Stop MCEs and NMIs during code patching
    Andi Kleen wrote:
    > +void stop_nmi(void)
    > +{
    > + ignore_nmis++;
    > + acpi_nmi_disable();
    > +}
    > +
    > +void restart_nmi(void)
    > +{
    > + ignore_nmis--;
    > + acpi_nmi_enable();
    > +}
    >

    Wouldn't it be better to just assign ignore_nmis rather than inc/dec it
    (and perhaps BUG on a double stop or restart)? Also, is
    acpi_nmi_disable/enable's use of on_each_cpu safe with interrupts
    disabled if we know there's only one CPU alive at this point?

    J
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-20 18:23    [W:0.029 / U:89.084 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site