Messages in this thread | | | Date | Mon, 2 Jul 2007 07:09:26 -0700 | From | "Ulrich Drepper" <> | Subject | Re: [patch 0/6] sys_indirect RFC - sys_indirect introduction |
| |
On 7/1/07, Davide Libenzi <davidel@xmailserver.org> wrote: > With the current API design you'd able to easily confine the "pre" code > inside the "set" function, and the "post" code inside the "unset" > function. It looks pretty clean to me, and allows to limit the knowledge > of sys_indirect, the more as possible inside kernel/indirect.c.
But this will not be applicable. We already discussed that each syscall likely needs its own set of flags etc. There really isn't much overlap if any which cannot be handled at least as well using a flat structure. You're adding major complications for something which IMO will never be usable. With the flat structure to whole overhead of sys_indirect is limited to a test for valid syscalls, copying the struct, making the call to the syscall function, and resetting the value in current. Very simple and fast. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |