lkml.org 
[lkml]   [2007]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: make SMP locks handling interact properly with CONFIG_DEBUG_RODATA (2nd try)
>>  void alternatives_smp_module_del(struct module *mod)
>> {
>> struct smp_alt_module *item;
>> - unsigned long flags;
>>
>> if (smp_alt_once || noreplace_smp)
>> return;
>>
>> - spin_lock_irqsave(&smp_alt, flags);
>> + spin_lock(&smp_alt);
>
>Unrelated change? Why? Should probably be separate patch.

Absolutely not: You can't call change_page_attr(), or more precisely
global_flush_tlb(), with interrupts disabled. And since interrupt disabling
is unneeded here afaics, I simply changed the calls instead of inventing
some ugly workaround.

I'll do the other adjustments you asked for, but it'll be only in about three
weeks from now...

Jan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-18 08:03    [W:0.073 / U:2.896 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site