lkml.org 
[lkml]   [2007]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sysfs: make sysfs_init_inode() static
On Wed, 18 Jul 2007 14:30:28 +0900, Tejun Heo wrote:
> With sysfs_fill_super() converted to use sysfs_get_inode(), there is
> no user of sysfs_init_inode() outside of fs/sysfs/inode.c. Make it
> static.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>

Looks good.

Acked-by: Jean Delvare <khali@linux-fr.org>

> ---
> fs/sysfs/inode.c | 2 +-
> fs/sysfs/sysfs.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> Index: work/fs/sysfs/inode.c
> ===================================================================
> --- work.orig/fs/sysfs/inode.c
> +++ work/fs/sysfs/inode.c
> @@ -133,7 +133,7 @@ static inline void set_inode_attr(struct
> */
> static struct lock_class_key sysfs_inode_imutex_key;
>
> -void sysfs_init_inode(struct sysfs_dirent *sd, struct inode *inode)
> +static void sysfs_init_inode(struct sysfs_dirent *sd, struct inode *inode)
> {
> inode->i_blocks = 0;
> inode->i_mapping->a_ops = &sysfs_aops;
> Index: work/fs/sysfs/sysfs.h
> ===================================================================
> --- work.orig/fs/sysfs/sysfs.h
> +++ work/fs/sysfs/sysfs.h
> @@ -71,7 +71,6 @@ extern void sysfs_remove_one(struct sysf
> extern int sysfs_addrm_finish(struct sysfs_addrm_cxt *acxt);
>
> extern void sysfs_delete_inode(struct inode *inode);
> -extern void sysfs_init_inode(struct sysfs_dirent *sd, struct inode *inode);
> extern struct inode * sysfs_get_inode(struct sysfs_dirent *sd);
> extern void sysfs_instantiate(struct dentry *dentry, struct inode *inode);
>


--
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-18 16:05    [W:0.391 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site