Messages in this thread | | | Date | Wed, 18 Jul 2007 17:59:52 +0800 | From | "rae l" <> | Subject | Re: [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c |
| |
On 7/18/07, David Miller <davem@davemloft.net> wrote: > From: Denis Cheng <crquan@gmail.com> > Date: Wed, 18 Jul 2007 10:41:03 +0800 > > > Because this function is only called by unregister_netdevice, > > this moving could make this non-global function static, > > and also remove its declaration in netdevice.h; > > > > Any further, function __dev_addr_discard is also just called by > > dev_mc_discard and dev_unicast_discard, keeping this two functions > > both in one c file could make __dev_addr_discard also static > > and remove its declaration in netdevice.h; > > > > Futhermore, the sequential call to dev_unicast_discard and then > > dev_mc_discard in unregister_netdevice have a similar mechanism that: > > (netif_tx_lock_bh / __dev_addr_discard / netif_tx_unlock_bh), > > they should merged into one to eliminate duplicates in acquiring and > > releasing the dev->_xmit_lock, this would be done in my following patch. > > > > Signed-off-by: Denis Cheng <crquan@gmail.com> > > Patch applied, thanks. Thanks for applying, too.
And then the dev_mcast.c is now only 256 lines long(versus dev.c 4052 lines), just left a few multicast related functions definition and "dev_mcast" procfs code, I have an idea to merge all code dev_mcast.c into dev.c, that would:
- remove two functions (__dev_addr_delete, __dev_set_rx_mode) from netdevice.h, and then tag them static, those two are also defined in dev.c and only called from dev_mcast.c,
- reducing one file would benefit the compilation process.
All in one word, I don't think the single file dev_mcast.c is needed anymore.
>
-- Denis Cheng Linux Application Developer
"One of my most productive days was throwing away 1000 lines of code." - Ken Thompson. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |