lkml.org 
[lkml]   [2007]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] smp_call_function_single() should be a macro on UP
From
From: Al Viro <viro@ftp.linux.org.uk>
Date: Tue, 17 Jul 2007 22:29:46 +0100

> ... or we end up with header include order problems from hell.
> E.g. on m68k this is 100% fatal - local_irq_enable() there
> wants preempt_count(), which wants task_struct fields, which
> we won't have when we are in smp.h pulled from sched.h.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Acked-by: David S. Miller <davem@davemloft.net>

I was going to fix the sparc64/UP build fallout by
adding linux/kernel.h include to linux/smp.h but that
definitely would not handle this m68k case at all.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-17 23:43    [W:0.038 / U:23.032 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site