lkml.org 
[lkml]   [2007]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

* Olaf Kirch <olaf.kirch@oracle.com> wrote:

> Can you try what happens if you change netif_rx_complete to something
> like this:
>
> if (test_bit(__LINK_STATE_POLL_LIST_FROZEN, &dev->state)) {
> dev->quota = dev->weight;
> return;
> }
>
> This is just a hack to make sure that we don't go to insanely negative
> quotas while sending packets through netpoll.

i've done the patch below, but it did not change the timeouts nor did it
solve the 'no network' problem. netconsole output hung earlier as well.

i can try other things too. (it would be best if you sent me
test/debug-patches, instead of letting me hack in the changes - that's
the surest way of ensuring that i test exactly what you intended.)

Ingo

------------->
Index: linux/include/linux/netdevice.h
===================================================================
--- linux.orig/include/linux/netdevice.h
+++ linux/include/linux/netdevice.h
@@ -1007,6 +1007,10 @@ static inline int netif_rx_reschedule(st
*/
static inline void __netif_rx_complete(struct net_device *dev)
{
+ if (test_bit(__LINK_STATE_POLL_LIST_FROZEN, &dev->state)) {
+ dev->quota = dev->weight;
+ return;
+ }
BUG_ON(!test_bit(__LINK_STATE_RX_SCHED, &dev->state));
list_del(&dev->poll_list);
smp_mb__before_clear_bit();
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2007-07-17 19:01    [W:0.093 / U:2.140 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site