lkml.org 
[lkml]   [2007]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 37/44] xen: add virtual network device driver
Stephen Hemminger wrote:
>> +struct netfront_info {
>> + struct list_head list;
>> + struct net_device *netdev;
>> +
>> + struct net_device_stats stats;
>>
>
> There is now a net_device_stats element inside net_device on
> 2.6.21 or later.
>

Ah, OK. Should I just do a s/stats/netdev->stats/? Is there a generic
get_stats routine as well?

>> +
>> + struct xen_netif_tx_front_ring tx;
>> + struct xen_netif_rx_front_ring rx;
>> +
>> + spinlock_t tx_lock;
>> + spinlock_t rx_lock;
>>
>
> It might be a performance advantage to reorder/align these
> structure elements to put transmit hot elements together, and
> put tx and rx on different cache lines?
>

Oh, right. I'd been meaning to look at that layout more closely.

Thanks,
J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-17 16:33    [W:0.034 / U:4.316 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site