lkml.org 
[lkml]   [2007]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [kvm-devel] [PATCH 2/3] KVM - Fix hypercall arguments
Avi Kivity wrote:
> Jeff Dike wrote:
>
>> It looks like kvm_hypercall is trying to match the system call
>> convention and mixed up the call number and first argument in the
>> 32-bit case.
>>
>> Signed-off-by: Jeff Dike <jdike@linux.intel.com>
>> --
>> drivers/kvm/kvm_main.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Index: kvm/drivers/kvm/kvm_main.c
>> ===================================================================
>> --- kvm.orig/drivers/kvm/kvm_main.c
>> +++ kvm/drivers/kvm/kvm_main.c
>> @@ -1351,8 +1351,8 @@ int kvm_hypercall(struct kvm_vcpu *vcpu,
>> } else
>> #endif
>> {
>> - nr = vcpu->regs[VCPU_REGS_RBX] & -1u;
>> - a0 = vcpu->regs[VCPU_REGS_RAX] & -1u;
>> + nr = vcpu->regs[VCPU_REGS_RAX] & -1u;
>> + a0 = vcpu->regs[VCPU_REGS_RBX] & -1u;
>> a1 = vcpu->regs[VCPU_REGS_RCX] & -1u;
>> a2 = vcpu->regs[VCPU_REGS_RDX] & -1u;
>> a3 = vcpu->regs[VCPU_REGS_RSI] & -1u;
>>
>>
>
> Anthony? I think you were hacking this area?
>

I make a similar change in my series.

Regards,

Anthony Liguori


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-17 15:45    [W:0.072 / U:2.856 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site