[lkml]   [2007]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats}

* Alexey Dobriyan <> wrote:

> On every open/close one struct seq_operations leaks.
> Kudos to /proc/slab_allocators.
> Signed-off-by: Alexey Dobriyan <>

ouch ...

Acked-by: Ingo Molnar <>

-stable material too, as far as timer_info/stats goes.

> - .release = seq_release,
> + .release = single_release,

i think seq_release() definitely needs to grow a WARN_ON() if it's being
used on an inode that was opened via single_open(). This bug is so
easily committed, and nothing but a small leak reminds us on it.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-07-17 14:39    [W:0.054 / U:0.108 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site