Messages in this thread | | | From | David Brownell <> | Subject | Re: [PATCH] minimal fixes for drivers/usb/gadget/m66592-udc.c | Date | Sun, 15 Jul 2007 19:54:36 -0700 |
| |
On Sunday 15 July 2007, Al Viro wrote: > On Sun, Jul 15, 2007 at 04:18:10PM -0700, David Brownell wrote: > > Re the leaks, in probe() request_irq() isn't cleaned up ... but it > > looked to me like the rest of the allocations did get cleaned up > > afer probe() errors. But remove() does indeed leak the memory you > > highlighted. > > Why not make ep0_buf a 16bit field in that struct?
Ask the driver author. :)
That should work, given proper byteswapping. It's only used to transmit certain results.
- Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |