Messages in this thread | | | Date | Sun, 15 Jul 2007 23:02:16 +0100 | From | Al Viro <> | Subject | Re: [PATCH] the wrong variable checked after request_irq() |
| |
On Mon, Jul 16, 2007 at 07:40:38AM +1000, Benjamin Herrenschmidt wrote: > On Sun, 2007-07-15 at 20:59 +0100, Al Viro wrote: > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> > > Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > > Out of curiosity, how did you pick it up ? You have some automated tool > to catch that (or sparse changes) or you just did -lots- of code > inspection ?
While testing sparse changes, actually (comparing pointers to null pointer constant spelled without a cast to void *)... That gave several hundred hits, most of them being immediately obvious (picking the lines by file and line number and looking through the list had eliminated all but about a dozen or two). Several were not... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |