lkml.org 
[lkml]   [2007]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 5/8] Immediate Values - kprobe header fix
    On Fri, Jul 13, 2007 at 09:24:44PM -0400, Mathieu Desnoyers wrote:
    > Since the immediate values depend on the same int3 handler as kprobes implements
    > for i386, we have to get architecture specific defines available for the kprobes
    > trap handler (especially restore_interrupts()) wven when CONFIG_KPROBES is not
    > selected.
    >
    > That kind of ifdef around a whole header does not make sense in the first place
    > anyway.
    >
    > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
    > CC: prasanna@in.ibm.com
    > CC: ananth@in.ibm.com
    > CC: anil.s.keshavamurthy@intel.com
    > CC: davem@davemloft.net
    > ---
    > include/linux/kprobes.h | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > Index: linux-2.6-lttng/include/linux/kprobes.h
    > ===================================================================
    > --- linux-2.6-lttng.orig/include/linux/kprobes.h 2007-07-13 18:47:57.000000000 -0400
    > +++ linux-2.6-lttng/include/linux/kprobes.h 2007-07-13 18:48:45.000000000 -0400
    > @@ -36,9 +36,9 @@
    > #include <linux/spinlock.h>
    > #include <linux/rcupdate.h>
    >
    > -#ifdef CONFIG_KPROBES
    > #include <asm/kprobes.h>

    but this one isn't available on architectures that don't have kprobes,
    so you can't include linux/kprobes.h in generic code without ifdef
    protection anymore.

    I'd say move the code to asm/kdebug.h if it's need by more than just
    kprobes.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-14 18:29    [W:0.022 / U:1.792 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site