Messages in this thread | | | Date | Fri, 13 Jul 2007 21:14:58 +0800 | From | WANG Cong <> | Subject | Re: [Resend][Patch] drivers/mtd/maps/tqm8xxl.c: Do some cleanups |
| |
On Fri, Jul 13, 2007 at 10:56:42AM +0100, David Woodhouse wrote: >On Fri, 2007-07-13 at 11:48 +0800, WANG Cong wrote: >> if(map_banks[idx] == NULL) { >> ret = -ENOMEM; >> - /* FIXME: What if some MTD devices were probed already? */ >> + /* FIXME: What if some MTD devices were probed >> + already? */ >> goto error_mem; >> } > > >That's just horrid. Leave it as it was. >
Sorry, I can't fully understand you. You mean only the above change is horrid or the entire patch?
I have some questions about mtd/maps drivers. Even when I use `make allyesconfig`, I still can't compile some drivers. I should add the corresponding CONFIGs manually. Why this? And I still got some errors and warnings, such as:
drivers/mtd/maps/pmcmsp-flash.c:40:22: error: msp_prom.h: No such file or directory drivers/mtd/maps/pmcmsp-flash.c:41:22: error: msp_regs.h: No such file or directory drivers/mtd/maps/pmcmsp-flash.c: In function 'init_msp_flash': drivers/mtd/maps/pmcmsp-flash.c:62: error: 'DEV_ID_REG' undeclared (first use in this function) drivers/mtd/maps/pmcmsp-flash.c:62: error: (Each undeclared identifier is reported only once drivers/mtd/maps/pmcmsp-flash.c:62: error: for each function it appears in.) drivers/mtd/maps/pmcmsp-flash.c:62: error: 'DEV_ID_SINGLE_PC' undeclared (first use in this function) drivers/mtd/maps/pmcmsp-flash.c:63: error: 'ELB_1PC_EN_REG' undeclared (first use in this function) drivers/mtd/maps/pmcmsp-flash.c:63: error: 'SINGLE_PCCARD' undeclared (first use in this function)
Did I miss something?
Thanks!
--
If loving computers is wrong, I don't want to be right. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |