Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [Cbe-oss-dev] [patch 0/4] Cell SPE logos | Date | Fri, 13 Jul 2007 12:05:19 +0200 |
| |
On Friday 13 July 2007, Geert Uytterhoeven wrote: > > > Summaries: > > > [1] fbdev: extract fb_show_logo_line() > > > [2] fbdev: Add fb_append_extra_logo() > > > > This one does give additional code and data to all fbdev users while only > > being useful to cell machines. Should we fix that? > > I can protect it by #ifdef CONFIG_PPC_CELL (as long as there are no other > users). Would that be OK?
If you want to have an #ifdef in there, it should probably be CONFIG_FB_EXTRA_LOGO and have that autoselected by CONFIG_SPU_BASE.
A nicer alternative to the #ifdef might be to mark it __init, so that it will just go away after boot. Not sure if that's safe though.
Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |