lkml.org 
[lkml]   [2007]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Make asm-generic/ioctl.h more generic using conditionals.
On Fri, 13 Jul 2007, Christoph Hellwig wrote:

> On Tue, Jul 10, 2007 at 06:33:26AM -0400, Robert P. J. Day wrote:
> > + * Let any architecture override either of the following before
> > + * including this file.
> > + */
> > +
> > +#ifndef _IOC_SIZEBITS
> > +# define _IOC_SIZEBITS 14
> > +#endif
> > +
> > +#ifndef _IOC_DIRBITS
> > +# define _IOC_DIRBITS 2
> > +#endif
>
> I don't think this is usefull. It just makes it less obvious to
> find this definition which must not change ever due to abi reasons
> anyway.

huh?

alpha:

#define _IOC_SIZEBITS 13
#define _IOC_DIRBITS 3

mips:

#define _IOC_SIZEBITS 13
#define _IOC_DIRBITS 3

powerpc:

#define _IOC_SIZEBITS 13
#define _IOC_DIRBITS 3

rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-13 12:03    [W:0.115 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site