Messages in this thread | | | Date | Thu, 12 Jul 2007 17:20:23 -0700 | From | Andrew Morton <> | Subject | Re: [GIT PATCH] USB patches for 2.6.22 |
| |
On Thu, 12 Jul 2007 17:03:46 -0700 (PDT) Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > On Thu, 12 Jul 2007, Greg KH wrote: > > > > Here are a bunch of USB patches and fixes against your 2.6.22 git tree. > > This also seems to contain some *totally*pointless* config variable > changes, that actually break simple things like "make oldconfig". > > This commit is insane: acb11c8b8020f1f1b2545152020675ef32d09a58 "USB: fix > gregkh-usb-usb-use-menuconfig-objects" > > It fixes nothing at all, quite the reverse. It makes the default be > somethign that breaks everything, and more irritatingly, even if you > answer 'y' (against the default), it breaks "make oldconfig", which will > have ignored all the old options and now will ask you for all of them > again. > > Yeah, that second part may be a "make oldconfig" bug, but regardless, > these kinds of Kconfig changes are BAD, BAD, BAD! > > I hate how people do just stupid things to "clean up" config files > (renaming config options etc), apparently never even bothering to think > about whether a question is sane or not, or whether normal users want to > see it or not. > > I know I'm not the only one who does "make oldconfig". Answering the same > questions over and over again is not something *anybody* wants to do. > > So please stop this madness. I've reverted the change that left the > menuconfig entry without a default, which at least fixes "make oldconfig", > but I just found this really irritating. I can pretty much guarantee that > nobody actually *tested* this change, did they? >
I went through the same pain a few weeks ago and I _thought_ all except one of these "fixes" got tossed. However it looks like the USB one escaped. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |