Messages in this thread | | | Date | Tue, 10 Jul 2007 04:02:45 -0500 | From | Matt Mackall <> | Subject | Re: [PATCH v2 -mm 1/9] netconsole: Cleanups, codingstyle, prettyfication |
| |
On Tue, Jul 10, 2007 at 02:49:25PM +0530, Satyam Sharma wrote: > From: Satyam Sharma <ssatyam@cse.iitk.ac.in> > > [1/9] netconsole: Cleanups, codingstyle, prettyfication > > (1) Remove unwanted headers. > (2) Mark __init and __exit as appropriate. > (3) Various trivial codingstyle and prettification stuff.
I don't much like what you've done in (3) because I personally think tabs should never appear anywhere but at the beginning of a line. Which is why we consistently ask for people not to mix codingstyle bits with substantive changes.
But what the hell..
Acked-by: Matt Mackall <mpm@selenic.com>
-- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |