Messages in this thread | | | Date | Tue, 10 Jul 2007 16:30:15 -0700 | From | Andrew Morton <> | Subject | Re: [EXT4 set 1][PATCH 2/2] Enable extents by default for ext4dev |
| |
On Sun, 01 Jul 2007 03:36:01 -0400 Mingming Cao <cmm@us.ibm.com> wrote:
> Turn on extents feature by default in ext4 filesystem. User could use > -o noextents to turn it off. >
Oh, there you go.
> > Index: linux-2.6.22-rc4/fs/ext4/super.c > =================================================================== > --- linux-2.6.22-rc4.orig/fs/ext4/super.c 2007-06-11 17:02:22.000000000 -0700 > +++ linux-2.6.22-rc4/fs/ext4/super.c 2007-06-11 17:03:09.000000000 -0700 > @@ -1546,6 +1546,12 @@ > > set_opt(sbi->s_mount_opt, RESERVATION); > > + /* > + * turn on extents feature by default in ext4 filesystem > + * User -o noextents to turn it off > + */ > + set_opt (sbi->s_mount_opt, EXTENTS); > +
Broken coding style.
Please feed all the ext4 patches through scripts/checkpatch.pl (preferably version 0.07 - see Andy's patch on lkml) and then consider addressing the (quite large) number of mistakes which are detected.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |