Messages in this thread | | | Date | Tue, 10 Jul 2007 21:01:23 +0200 | From | Adrian Bunk <> | Subject | Re: [2.6 patch] slub.c:early_kmem_cache_node_alloc() shouldn't be __init |
| |
On Tue, Jul 10, 2007 at 11:33:15AM -0700, Christoph Lameter wrote: > On Tue, 10 Jul 2007, Adrian Bunk wrote: > > > This patch fixes the following section mismatch: > > Nack. > > Can you remove the warning? early_kmem_cache_node_alloc is only used > during bootstrap. But it is called from a function that is also used > later.
The alternative is "noinline __init_refok" - the noinline is required because modern gcc versions already make it non-__init by inlining it into init_kmem_cache_nodes() without.
But I'm not convinced it's really worth manually forcing noinline only for moving a few bytes to __init in the CONFIG_NUMA=y case - in the long term this will only bit rot.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |