Messages in this thread | | | From | Andi Kleen <> | Subject | Re: blink driver power saving | Date | Sun, 1 Jul 2007 23:26:29 +0200 |
| |
On Sunday 01 July 2007 18:50:35 Stephen Hemminger wrote: > The blink driver wakes up every jiffies which wastes power unnecessarily. > Using a notifier gives same effect. Also add ability to unload module.
It's really a debugging tool where you normally don't care about details like this. I wrote it to get visual feedback during kdump, but it is nothing you should ever run during normal operation.
But I don't get how your patch is supposed to work. The blink driver is not supposed to blink after panic -- panic does that anyways -- but always. So hooking it into the panic notifier chain which is only called on panic makes about zero sense.
If it's really needed to fix the wakeup issue the interface to the keyboard blinking would need to be changed.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |