[lkml]   [2007]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[patch 14/54] e1000: disable polling before registering netdevice
-stable review patch.  If anyone has any objections, please let us know.
From: Auke Kok <>

To assure the symmetry of poll enable/disable in up/down, we should
initialize the netdevice to be poll_disabled at load time. Doing
this after register_netdevice leaves us open to another race, so
lets move all the netif_* calls above register_netdevice so the
stack starts out how we expect it to be.

Signed-off-by: Auke Kok <>
Cc: Herbert Xu <>
Cc: Doug Chapman <>
Signed-off-by: Jeff Garzik <>
Signed-off-by: Chris Wright <>
Signed-off-by: Greg Kroah-Hartman <>
drivers/net/e1000/e1000_main.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
--- linux-
+++ linux-
@@ -1153,13 +1153,16 @@ e1000_probe(struct pci_dev *pdev,

- strcpy(netdev->name, "eth%d");
- if ((err = register_netdev(netdev)))
- goto err_register;
/* tell the stack to leave us alone until e1000_open() is called */
+#ifdef CONFIG_E1000_NAPI
+ netif_poll_disable(netdev);
+ strcpy(netdev->name, "eth%d");
+ if ((err = register_netdev(netdev)))
+ goto err_register;

DPRINTK(PROBE, INFO, "Intel(R) PRO/1000 Network Connection\n");

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-06-08 09:41    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean