lkml.org 
[lkml]   [2007]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 51/54] SPARC64: Fix _PAGE_EXEC_4U check in sun4u I-TLB miss handler.
    -stable review patch.  If anyone has any objections, please let us know.
    ---------------------

    From: David Miller <davem@davemloft.net>

    It was using an immediate _PAGE_EXEC_4U value in an 'and'
    instruction to perform the test. This doesn't work because
    the immediate field is signed 13-bit, this the mask being
    tested against the PTE was 0x1000 sign-extended to 32-bits
    instead of just plain 0x1000.

    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    arch/sparc64/kernel/itlb_miss.S | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- linux-2.6.21.4.orig/arch/sparc64/kernel/itlb_miss.S
    +++ linux-2.6.21.4/arch/sparc64/kernel/itlb_miss.S
    @@ -11,12 +11,12 @@
    /* ITLB ** ICACHE line 2: TSB compare and TLB load */
    bne,pn %xcc, tsb_miss_itlb ! Miss
    mov FAULT_CODE_ITLB, %g3
    - andcc %g5, _PAGE_EXEC_4U, %g0 ! Executable?
    + sethi %hi(_PAGE_EXEC_4U), %g4
    + andcc %g5, %g4, %g0 ! Executable?
    be,pn %xcc, tsb_do_fault
    nop ! Delay slot, fill me
    stxa %g5, [%g0] ASI_ITLB_DATA_IN ! Load TLB
    retry ! Trap done
    - nop

    /* ITLB ** ICACHE line 3: */
    nop
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-08 10:03    [W:0.042 / U:35.396 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site