lkml.org 
[lkml]   [2007]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: 2.6.22-rc4-mm2: Assigning IP address fails
    On Thu, Jun 07, 2007 at 03:06:53PM -0700, Andrew Morton wrote:
    >
    > > I'm not able to bring an ethernet interface down and back up again
    > > with this if avahi-autoipd is installed on my Ubuntu boxes. I've seen
    > > it on three different computers with different NIC hardware.

    Sorry, it was my patch. This patch should fix it.

    [IPV4]: Do not remove idev when addresses are cleared

    Now that we create idev before addresses are added, it no longer makes
    sense to remove them when addresses are all deleted.

    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

    Cheers,
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
    --
    diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
    index 354e800..0cf813f 100644
    --- a/net/ipv4/devinet.c
    +++ b/net/ipv4/devinet.c
    @@ -327,12 +327,8 @@ static void __inet_del_ifa(struct in_device *in_dev, struct in_ifaddr **ifap,
    }

    }
    - if (destroy) {
    + if (destroy)
    inet_free_ifa(ifa1);
    -
    - if (!in_dev->ifa_list)
    - inetdev_destroy(in_dev);
    - }
    }

    static void inet_del_ifa(struct in_device *in_dev, struct in_ifaddr **ifap,
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-06-08 00:59    [W:0.022 / U:59.612 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site