lkml.org 
[lkml]   [2007]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 002 of 2] Make sure readv stops reading when it hits end-of-file.

    The do_loop_readv_writev implementation of readv breaks out of the
    loop as soon as a single read request didn't fill it's buffer:
    if (nr != len)
    break;

    The generic_file_aio_read version doesn't. So if it hits EOF
    before the end of the list of buffers, it will try again on the next
    buffer. If the file was extended in the mean time, this will
    produce a bad result.

    Signed-off-by: Neil Brown <neilb@suse.de>

    ### Diffstat output
    ./mm/filemap.c | 2 ++
    1 file changed, 2 insertions(+)

    diff .prev/mm/filemap.c ./mm/filemap.c
    --- .prev/mm/filemap.c 2007-06-07 11:34:24.000000000 +1000
    +++ ./mm/filemap.c 2007-06-07 11:39:35.000000000 +1000
    @@ -1206,6 +1206,8 @@ generic_file_aio_read(struct kiocb *iocb
    retval = retval ?: desc.error;
    break;
    }
    + if (desc.count > 0)
    + break;
    }
    }
    out:
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-06-07 03:51    [W:0.020 / U:29.932 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site