| Date | Tue, 5 Jun 2007 23:54:41 -0700 | | From | Andrew Morton <> | | Subject | Re: [-mm patch] kernel/sched{,_fair}.c: make code static |
| |
On Tue, 5 Jun 2007 23:50:56 +0200 Adrian Bunk <bunk@stusta.de> wrote:
> This patch makes some needlessly global code static. > > Signed-off-by: Adrian Bunk <bunk@stusta.de> > > --- > > BTW: Please don't #include C files in sched.c
Yeah.
> -long div64_s(s64 divident, unsigned long divisor) > +static long div64_s(s64 divident, unsigned long divisor)
"divident" does appear to be a word, but I suspect "dividend" was intended.
Why is this function lurking in the CPU scheduler rather than in lib/somewhere.c?
Doesn't an unsigned divide give the same result as a signed one? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|