Messages in this thread | | | Subject | Re: [PATCH 2/2] ehea: Receive SKB Aggregation | From | Christoph Raisch <> | Date | Mon, 4 Jun 2007 14:09:47 +0200 |
| |
Christoph Hellwig wrote on 31.05.2007 15:41:18:
> I'm still very unhappy with having all this in various drivers. There's > a lot of code that can be turned into generic library functions, and even > more code that could be made generic with some amount of refactoring.
Yes, we'd also prefer to use a generic function, but we first would want to get some "real world" experience how our driver behaves with LRO to be even able to define requirements for such a generic function. A lot of this is tied into pathlengths, caching, and why does that help compared to a different TCP receive side processing? In a perfect world we shouldn't see a diffference if this is enabled or not, but measurements indicate something completely different at 10gbit.
Gruss / Regards Christoph Raisch
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |