lkml.org 
[lkml]   [2007]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 0/6] Convert all tasklets to workqueues
    Steven Rostedt wrote:
    > I had very little hope for this magic switch to get into mainline. (maybe
    > get it into -mm) But the thing was is that tasklets IMHO are over used.
    > As Ingo said, there are probably only 2 or 3 places in the kernel that a
    > a switch to work queue conversion couldn't solve.

    This is purely a guess, backed by zero evidence.

    These network drivers were hand-tuned to use tasklets. Sure it will
    WORK as a workqueue, but that says nothing equivalence.


    > Those places could then
    > probably be solved by a different design (yes that would take work).

    Network driver patches welcome :)


    > Tasklets are there because there
    > wasn't work queues or kthreads at the time of solving the solution that
    > tasklets solved.

    Completely false, at least in network driver land. Threads existed and
    were used (proof: 8139too, among others).

    Kernel threads were not used for hot path network packet shovelling
    because they were too damn slow. Tasklets were single-threaded, fast,
    simple and immediate. Workqueues today are simple and almost-fast.

    Jeff


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-29 16:29    [W:0.045 / U:62.828 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site