Messages in this thread | | | From | Uli Luckas <> | Subject | Re: [PATCH -mm] PM: Prevent frozen user mode helpers from failing the freezing of tasks (rev. 2) | Date | Tue, 26 Jun 2007 10:07:38 +0200 |
| |
On Monday, 25. June 2007, Rafael J. Wysocki wrote: > [I hope the ACKs still apply.] > Mine does
> +static void helper_lock(void) > +{ > + atomic_inc(&running_helpers); > + smp_mb__after_atomic_inc(); > +} > + > +static void helper_unlock(void) > +{ > + if (atomic_dec_and_test(&running_helpers)) > + wake_up(&running_helpers_waitq); > +} > + > +static void register_pm_notifier_callback(void) > +{ > + pm_notifier(usermodehelper_pm_callback, 0); > +} > +#else /* CONFIG_PM */
> +static inline void helper_lock(void) {} > +static inline void helper_unlock(void) {} > +static inline void register_pm_notifier_callback(void) {} >
Sorry for not realising this before, but I think, we should also inline the actual implementations of helper_lock, helper_unlock and register_pm_notifier_callback
Regards Uli
--
------- ROAD ...the handyPC Company - - - ) ) )
Uli Luckas Software Development
ROAD GmbH Bennigsenstr. 14 | 12159 Berlin | Germany fon: +49 (30) 230069 - 64 | fax: +49 (30) 230069 - 69 url: www.road.de
Amtsgericht Charlottenburg: HRB 96688 B Managing directors: Hans-Peter Constien, Hubertus von Streit - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |