Messages in this thread | | | Date | Mon, 25 Jun 2007 15:43:41 -0500 | Subject | Re: [PATCH v2] pcmcia: CompactFlash driver for PA Semi Electra boards | From | (Olof Johansson) |
| |
On Mon, Jun 25, 2007 at 08:39:09PM +0100, Christoph Hellwig wrote: > On Mon, Jun 25, 2007 at 12:12:21PM -0500, Olof Johansson wrote: > > Driver for the CompactFlash slot on the PA Semi Electra eval board. It's > > a simple device sitting on localbus, with interrupts and detect/voltage > > control over GPIO. > > > > The driver is implemented as an of_platform driver, and adds localbus > > as a bus being probed by the of_platform framework. > > Looks good to me. The only odd thing is the inconsistant use of > #ifdef CONFIG_PCMCIA in setup.c.
Thanks, and thanks for the review.
The ifdef is needed since for CONFIG_PCMCIA=n builds, the bus notifier isn't available. I wanted to do the bus notifier registration explicitly before the of_platform bus probe to avoid later surprises due to reordered initcalls in case it was split up in it's own initcall.
I could add the code under ifdef as well, but it didn't seem too critical. Once the second major board comes along I'll probably move it out to a per-board file, there's no real need for it just yet.
-Olof
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |