Messages in this thread | | | Date | Mon, 25 Jun 2007 06:56:36 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] pcmcia: CompactFlash driver for PA Semi Electra boards |
| |
> +static int bus_notify(struct notifier_block *nb, unsigned long action, > + void *data) > +{ > + struct device *dev = data; > + > + printk("bus notify called\n"); > + > + /* We are only intereted in device addition */ > + if (action != BUS_NOTIFY_ADD_DEVICE) > + return 0; > + > + /* We use the direct ops for localbus */ > + dev->archdata.dma_ops = &dma_direct_ops; > + > + return 0; > +}
Sorry for not coming back to you after the last posting of the patch, but I still really this bit of the code. We don't set dma ops from a driver anywhere else in the tree, so I'd really prefer if you could handle this in architecture code somewhere. Especially as dma_direct_ops and the pcmcia_bug_type shouldn't really be something exported to users.
Also this code is unlogic if not buggy. Just because you have one electra bridge it doesn't mean all pcmcia is driven by it. In fact I'm pretty sure there are cardbus/pcmcia bridges that can be plugged into plain pci slots. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |