Messages in this thread | | | Date | Sun, 24 Jun 2007 21:48:43 -0700 | From | Petr Vandrovec <> | Subject | Re: [PATCH try #2] security: Convert LSM into a static interface |
| |
James Morris wrote: > Convert LSM into a static interface, as the ability to unload a security > module is not required by in-tree users and potentially complicates the > overall security architecture.
Hello,
> -module_param(debug, bool, 0600); > -MODULE_PARM_DESC(debug, "Debug enabled or not"); > +static int __init root_plug_debug(char *str) > +{ > + debug = simple_strtol(str, NULL, 0); > + return 1; > +} > +__setup("root_plug_debug=", root_plug_debug);
is this necessary? What about just documenting root_plug.{vendor_id,product_id,debug}, so it won't break existing root_plug users (if there are any) ? I thought that typed module_param() is prefered over untyped __setup()...
Thanks, Petr
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |