Messages in this thread | | | From | Neil Brown <> | Date | Mon, 25 Jun 2007 09:01:32 +1000 | Subject | Re: [patch 1/3] add the fsblock layer |
| |
On Sunday June 24, npiggin@suse.de wrote: > > +#define PG_blocks 20 /* Page has block mappings */ > +
I've only had a very quick look, but this line looks *very* wrong. You should be using PG_private.
There should never be any confusion about whether ->private has buffers or blocks attached as the only routines that ever look in ->private are address_space operations (or should be. I think 'NULL' is sometimes special cased, as in try_to_release_page. It would be good to do some preliminary work and tidy all that up).
Why do you think you need PG_blocks?
NeilBrown - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |